Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waf/helpers: prevent panic during ExpandActivatedRule method #22978

Merged
merged 2 commits into from
Feb 7, 2022
Merged

waf/helpers: prevent panic during ExpandActivatedRule method #22978

merged 2 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 6, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22500
Closes #22378

Output from acceptance testing:

--- PASS: TestAccWAFRuleGroup_noActivatedRules (24.10s)
--- PASS: TestAccWAFRuleGroup_disappears (32.71s)
--- PASS: TestAccWAFRuleGroup_basic (33.40s)
--- PASS: TestAccWAFRuleGroup_tags (52.01s)
--- PASS: TestAccWAFRuleGroup_changeActivatedRules (58.68s)
--- PASS: TestAccWAFRuleGroup_changeNameForceNew (59.35s)

--- PASS: TestAccWAFRegionalRuleGroup_noActivatedRules (29.69s)
--- PASS: TestAccWAFRegionalRuleGroup_disappears (43.75s)
--- PASS: TestAccWAFRegionalRuleGroup_basic (48.69s)
--- PASS: TestAccWAFRegionalRuleGroup_changeActivatedRules (68.40s)
--- PASS: TestAccWAFRegionalRuleGroup_changeNameForceNew (71.84s)
--- PASS: TestAccWAFRegionalRuleGroup_tags (80.44s)

@anGie44 anGie44 changed the title r/waf_rule_group: prevent panic during ExpandActivatedRule method waf/helpers: prevent panic during ExpandActivatedRule method Feb 6, 2022
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. labels Feb 6, 2022
@anGie44 anGie44 added the service/wafregional Issues and PRs that pertain to the wafregional service. label Feb 6, 2022
@anGie44 anGie44 marked this pull request as ready for review February 6, 2022 19:56
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Feb 6, 2022
ewbankkit
ewbankkit approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v4.0.0 milestone Feb 7, 2022
@anGie44 anGie44 merged commit bb4faf1 into main Feb 7, 2022
@anGie44 anGie44 deleted the b-waf-expand-activated-rule-panic branch February 7, 2022 17:12
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Feb 14, 2022
Closed
ewbankkit pushed a commit that referenced this pull request Feb 17, 2022
@anGie44 @ewbankkit
Update CHANGELOG for #22978
d00e757
@ewbankkit ewbankkit mentioned this pull request Feb 17, 2022
Merged
ewbankkit added a commit that referenced this pull request Feb 17, 2022
@ewbankkit
Merge pull request #23253 from hashicorp/b-backport-22978
297c504 
Backport of #22978 to `release/3.x`
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service. service/wafregional Issues and PRs that pertain to the wafregional service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Resource aws_waf_rule_group provider crash (3.66.0+) WAF V1 Provider
2 participants
@anGie44 @ewbankkit